Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5828 - feathers update #4568

Merged
merged 34 commits into from
Dec 6, 2023
Merged

BC-5828 - feathers update #4568

merged 34 commits into from
Dec 6, 2023

Conversation

virgilchiriac
Copy link
Contributor

@virgilchiriac virgilchiriac commented Nov 21, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

BC-5828
follow-up: #4573

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

SevenWaysDP and others added 19 commits October 27, 2023 12:26
@virgilchiriac virgilchiriac mentioned this pull request Nov 21, 2023
Closed
3 tasks
@virgilchiriac virgilchiriac mentioned this pull request Nov 24, 2023
Merged
3 tasks
SevenWaysDP
SevenWaysDP reviewed Nov 27, 2023
View reviewed changes
test/services/oauth2/mock.js Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@virgilchiriac
undo hydra url config
22cdc5f 
config adjustment
@virgilchiriac virgilchiriac force-pushed the BC-5828-feathers-update branch from 2e8fcb3 to 22cdc5f Compare November 28, 2023 12:20
@virgilchiriac virgilchiriac force-pushed the BC-5828-feathers-update branch from c187833 to 4373645 Compare November 29, 2023 16:43
@virgilchiriac virgilchiriac force-pushed the BC-5828-feathers-update branch from 4373645 to b5c18df Compare November 29, 2023 16:56
virgilchiriac
virgilchiriac commented Nov 30, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@virgilchiriac
Copy link
Contributor Author

see other PR #4608

virgilchiriac
virgilchiriac commented Dec 5, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@virgilchiriac virgilchiriac enabled auto-merge (squash) December 6, 2023 09:59
@virgilchiriac virgilchiriac merged commit 092c2f9 into main Dec 6, 2023
47 of 48 checks passed
@virgilchiriac virgilchiriac deleted the BC-5828-feathers-update branch December 6, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevenWaysDP SevenWaysDP SevenWaysDP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@virgilchiriac @SevenWaysDP